-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the query_batch
method of the deepsetcloud document store - …
#3724
Fixing the query_batch
method of the deepsetcloud document store - …
#3724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @zoltan-fedor thx for the fix!
Hey @zoltan-fedor I think you need to update your branch with the current main to get the build to pass. It looks like your branch is ~265 commits behind the current main branch of Haystack. |
@zoltan-fedor I updated the branch for you. Hope, that's ok :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix! 🙌
Related Issues
Proposed Changes:
This is an easy fix of a simple code syntax issue - wrong indentation causing logical error in the code of the deepsetcloud document store's
query_batch()
method.How did you test it?
All tests were passing before, so this is tested by code logic only.
Notes for the reviewer
N/A
Checklist