-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs in loading code from yaml #2705
Conversation
@masci Nice catch regarding the |
@masci btw why did the md file of this tutorial get updated? Was there a merge before without running the |
I have no idea but I'm not very happy about the bot cluttering my PR :/ |
Weird! The changes come from this PR probably, where it seems like the bot was working fine... We should really do something about this 😅 |
Please merge master after we merge in #2714, so the bot will stop spamming 😅 |
719b219
to
304d9e6
Compare
0784a3b
to
3b29218
Compare
3b29218
to
4fa12d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* fix bug in loading code from yaml
Related Issue(s): no issue, addressing failing tests on
master
Proposed changes:
.endswith
to determine if the instance is a leaf of the hierarchy tree. That check would mistakenly considerBaseElasticsearchDocumentstore.__init__
be the same asElasticsearchDocumentstore.__init__
. We now manipulate and compare the actual tokens composing the fully qualified name of a__init__
method._get_signature
that was used to recursively collect all the params for all the constructors calls chain, the code isn't used anymore.Pre-flight checklist