-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DC SDK - load pipeline from deepset cloud #2013
Conversation
Hey @ArzelaAscoIi, I would suggest to keep the separation between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Left a few minor comments - mainly around documentation.
One bigger conceptual question is probably whether to stick in the future with the "two pipelines in one YAML" design. I see more and more cases where it would make more sense to define a Pipeline
as the combination of 1x index and 1x query "pipeline/flow/graph".
In that case, you would always load both here, and maybe we split pipeline.run()
into pipeline.run()
and pipeline.index()
?
Probably out of scope for this issue, but we should discuss and decide on this in the next weeks.
* minimal DCDocumentStore * support filters * implement get_documents_by_id * handle not existing documents * add docstrings * auth added * add tests * generate docs * Add latest docstring and tutorial changes * add responses to dev dependencies * fix tests * support query() and quey_by_embedding() * Add latest docstring and tutorial changes * query tests added * read api_key and api_endpoint from env * Add latest docstring and tutorial changes * support query() and quey_by_embedding() * query tests added * Add latest docstring and tutorial changes * Add latest docstring and tutorial changes * support dynamic similarity and return_embedding values * Add latest docstring and tutorial changes * adjust KeywordDocumentStore description * refactoring * Add latest docstring and tutorial changes * implement get_document_count and raise on all not implemented methods * Add latest docstring and tutorial changes * don't use abbreviation DC in comments and errors * Add latest docstring and tutorial changes * docstring added to KeywordDocumentStore * Add latest docstring and tutorial changes * enhanced api key set * split tests into two parts * change setup.py in order to work around build cache * added link * Add latest docstring and tutorial changes * rename DCDocumentStore to DeepsetCloudDocumentStore * Add latest docstring and tutorial changes * remove dc.py * reinsert link to docs * fix imports * Add latest docstring and tutorial changes * better test structure Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ArzelaAscoIi <kristof.herrmann@rwth-aachen.de>
… into pipelines-from-to-dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
Proposed changes:
Deepset cloud SDK - load, run and evaluate pipelines from deepset cloud. We already have the possibility to load an existing pipeline from a
yaml
configuration. As another origin we can now load pipelines from deepset cloud.Usage
Set environment variables:
and run the following lines:
Status (please check what you already did):
closes #2002