Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RCIReader for TableQA #1909

Merged
merged 8 commits into from
Jan 3, 2022
Merged

Add RCIReader for TableQA #1909

merged 8 commits into from
Jan 3, 2022

Conversation

bogdankostic
Copy link
Contributor

@bogdankostic bogdankostic commented Dec 17, 2021

This PR adds the possibility to use Row-Column-Intersection models as described in this paper and its associated repository.

Open To-Dos:

  • Doc strings
  • Tests

@bogdankostic bogdankostic requested a review from tholor December 30, 2021 17:29
@bogdankostic bogdankostic added topic:tableQA type:feature New feature or request labels Dec 30, 2021
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one tiny comment regarding docs. Feel free to merge after this has been addressed

Each row and each column is given a score with regard to the query by two separate models. The score of each cell
is then calculated as the sum of the corresponding row score and column score. Accordingly, the predicted answer is
the cell with the highest score.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add one line that explains the core pros/cons to TableReader? (e.g. confidence scores, aggregation options ...)

@tholor tholor changed the title Add RCIReader Add RCIReader for TableQA Jan 3, 2022
@bogdankostic bogdankostic merged commit 45df18c into master Jan 3, 2022
@bogdankostic bogdankostic deleted the add_rci_reader branch January 3, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tableQA type:feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants