Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend TranslationWrapper to work with QA Generation #1905

Merged
merged 13 commits into from
Jan 3, 2022
Merged

Extend TranslationWrapper to work with QA Generation #1905

merged 13 commits into from
Jan 3, 2022

Conversation

julian-risch
Copy link
Member

@julian-risch julian-risch commented Dec 17, 2021 •
edited
Loading

Proposed changes:

if __name__ == "__main__":
    tutorial13_question_generation()

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Updated tutorial

@julian-risch julian-risch added type:feature New feature or request topic:pipeline labels Dec 17, 2021
@julian-risch julian-risch marked this pull request as ready for review December 17, 2021 15:44
@julian-risch julian-risch requested a review from tholor December 20, 2021 16:24
@julian-risch
Copy link
Member Author

Hi @tholor , @ArzelaAscoIi and I would like to ask for your initial feedback on this PR. If everything looks good to you, we will update the documentation and maybe add an example to tutorial 13.

@julian-risch julian-risch changed the title draft translationwrapper example Extend TranslationWrapper to work with QA Generation Dec 20, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ArzelaAscoIi
ArzelaAscoIi approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tholor
tholor approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left one tiny comment. Feel free to merge afterwards.

haystack/nodes/translator/base.py Outdated
translation_results = {}

if results is not None:
if results is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate if?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it :)

@julian-risch julian-risch merged commit a846be9 into master Jan 3, 2022
@julian-risch julian-risch deleted the translate_qa_pairs branch January 3, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArzelaAscoIi ArzelaAscoIi ArzelaAscoIi approved these changes

@tholor tholor tholor approved these changes

Assignees

@julian-risch julian-risch

@ArzelaAscoIi ArzelaAscoIi

Labels
topic:pipeline type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julian-risch @tholor @ArzelaAscoIi