-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pytorch] Allows to load libstdc++.so.6 form different location #2929
Conversation
@@ -18,17 +18,21 @@ | |||
import org.testng.annotations.BeforeClass; | |||
import org.testng.annotations.Test; | |||
|
|||
public class LibUtilsTest { | |||
// Ensure this test run first | |||
public class ALibUtilsTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change from LibUtils
to ALibUtils
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testng use alphabetical order to run the unittest classes. The engine is only initialized once in the JVM. We want make sure this test executed first in all tests.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2929 +/- ##
============================================
+ Coverage 72.08% 72.29% +0.20%
- Complexity 5126 7275 +2149
============================================
Files 473 721 +248
Lines 21970 32464 +10494
Branches 2351 3384 +1033
============================================
+ Hits 15838 23471 +7633
- Misses 4925 7380 +2455
- Partials 1207 1613 +406 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this will provide added flexibility
Description
Brief description of what this PR is about