Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Safe creation info fallback #2744

Merged
merged 21 commits into from
Feb 26, 2025
Merged

Implement Safe creation info fallback #2744

merged 21 commits into from
Feb 26, 2025

Conversation

DarksightKellar
Copy link
Contributor

Fallback uses safe-client API.
Appears to work only with mainnet safes.

Screenshot 2025-02-25 at 19 28 06 Screenshot 2025-02-25 at 19 31 04

Da-Colon and others added 12 commits February 24, 2025 17:07
@Da-Colon @adamgall
Refactor useSafeAPI to accept a public client parameter for fetching …
95f4375 
…safe data
@adamgall
Batch all of these calls up into a multicall
15a8caa
TODO
29f6656
@adamgall
Remove leftover unused dependency
041645f
@adamgall
Remove "--force" from dev script
3140b6f
@adamgall
Two things:
fe89f29 
1. instantiate public client in useSafeApi hook, save it on class property, don't need to pass into the one specific call
2. start to refactor fallback code
@adamgall
Refactor fallback code into independent Safe SDK functions
d30e288
@adamgall
comments for context
7aa7878
@adamgall
Add newline
56d2085
@DarksightKellar
3 things:
63cbd11 
- Have useSearchDao use EnhancedSafeApiKit
- Allow EnhancedSafeApiKit to be instantiated with a specified chain via network config arg
- Implement fallback: a direct API call to `safe-client`
@DarksightKellar
Refactor EnhancedSafeApiKit.request to be more readable
6382845
@DarksightKellar
EnhancedSafeApiKit can initialise its own publicClient from networkCo…
195358d 
…nfig. Remove publicClient constructor arg
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 25, 2025 •
edited
Loading

Deploying decent-interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2147b0e
Status:⚡️  Build in progress...

View logs

adamgall and others added 4 commits February 25, 2025 16:26
@adamgall
Remove caching layer from useSafeAPI
1ad9c88
@adamgall @johnqh
Remove getSafeCreationInfo Safe API call loop, navigate directly to D…
99dc5df 
…AO home after DAO Creation transaction is confirmed

Co-authored-by: John Huang <johnqh@users.noreply.github.com>
@adamgall @johnqh
Build patterns into useSafeAPI
0ad7979 
Co-authored-by: John Huang <johnqh@users.noreply.github.com>
Some Safe Client code
7599d1a
@adamgall adamgall changed the base branch from ENG-NoISSUE-load-safe-info-from-contracts to main February 26, 2025 04:24
@adamgall adamgall changed the base branch from main to release/v0.7.2 February 26, 2025 04:25
@johnqh johnqh merged commit 8cb1d3a into release/v0.7.2 Feb 26, 2025
3 of 4 checks passed
@johnqh johnqh deleted the safe-creation-info-fallback branch February 26, 2025 05:54
@sentry-io Sentry.io
Copy link

sentry-io bot commented Feb 26, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Failed to getMultisigTransactions() //home View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgall adamgall Awaiting requested review from adamgall

@Da-Colon Da-Colon Awaiting requested review from Da-Colon

@johnqh johnqh Awaiting requested review from johnqh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DarksightKellar @johnqh @Da-Colon @adamgall