[ENG-199] Prevent proposal submission when selecting term
#2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event propergation to submit form
Da-Colon
requested review from
adamgall,
johnqh,
DarksightKellar and
mudrila
adamgall
approved these changes
Feb 10, 2025
DarksightKellar
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-199
Before:
After:
Changes
Scratched my head a little, it APPEARS when a type is not defined for the
MenuButtonit gives it thesubmittype. which in this case as thisMenuis nested within aform, tries to submit the form. Defining it as type button seems to work with no side-effects