[ENG-205] handle missing/malformed query

[Da-Colon]

Closes ENG-205

[linear]

ENG-205 Handle Mal-formed and missing URL query params

[cloudflare-workers-and-pages]

Deploying decent-interface with    Cloudflare Pages

Latest commit:	319aa18
Status:	✅  Deploy successful!
Preview URL:	https://1b1bd75f.decent-interface.pages.dev
Branch Preview URL:	https://eng-205-handle-missing-dao-a.decent-interface.pages.dev

View logs

[DarksightKellar]

there's a 🐞

[DarksightKellar]

Looks good to me and testing works as intended, but a suggestion. The way it works now, some malformed urls lead to an error page:

• https://eng-205-handle-missing-dao-a.decent-interface.pages.dev/home?dao=sesp:0x149116ea8ef5Bae98C98268Bd5b55330A385D191&size=10&page=1
• https://eng-205-handle-missing-dao-a.decent-interface.pages.dev/home?dao=sep%3A0x149116ea8ef5Bae98C98268Bd5b55330A385D191----&page=1&size=10
• https://eng-205-handle-missing-dao-a.decent-interface.pages.dev/nothing_here?dao=sep%3A0x149116ea8ef5Bae98C98268Bd5b55330A385D191&page=1&size=10

But then urls like:

• https://eng-205-handle-missing-dao-a.decent-interface.pages.dev/?dao=sep%3A0x149116ea8ef5Bae98C98268Bd5b55330A385D191&page=1&size=10
• https://eng-205-handle-missing-dao-a.decent-interface.pages.dev/home?daobad=sep%3A0x149116ea8ef5Bae98C98268Bd5b55330A385D191&page=1&size=10
  ... redirect to the landing page in a flash.

I'm thinking a redirect to one of these error pages would be a much smoother experience?

[Da-Colon]

Looks good to me and testing works as intended, but a suggestion. The way it works now, some malformed urls lead to an error page:

• https://eng-205-handle-missing-dao-a.decent-interface.pages.dev/home?dao=sesp:0x149116ea8ef5Bae98C98268Bd5b55330A385D191&size=10&page=1
• https://eng-205-handle-missing-dao-a.decent-interface.pages.dev/home?dao=sep%3A0x149116ea8ef5Bae98C98268Bd5b55330A385D191----&page=1&size=10
• https://eng-205-handle-missing-dao-a.decent-interface.pages.dev/nothing_here?dao=sep%3A0x149116ea8ef5Bae98C98268Bd5b55330A385D191&page=1&size=10

But then urls like:

• https://eng-205-handle-missing-dao-a.decent-interface.pages.dev/?dao=sep%3A0x149116ea8ef5Bae98C98268Bd5b55330A385D191&page=1&size=10
• https://eng-205-handle-missing-dao-a.decent-interface.pages.dev/home?daobad=sep%3A0x149116ea8ef5Bae98C98268Bd5b55330A385D191&page=1&size=10
  ... redirect to the landing page in a flash.

I'm thinking a redirect to one of these error pages would be a much smoother experience?

👍 I originally do that because, in my brain I was like router can't access that error boundary, but then I was like I can just return that component....lol. I think this covers your scenarios to all behave the same now

*note if home is missing it doesn't go anywhere or show error page.