Fix DeFi Positions fetching and transforming #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Moralis API to support non-paginated endpoints - Enhance DefiResponse transformer to map Moralis response to a more structured format - Add fetchMoralisDefi helper function for DeFi-specific API calls - Improve type definitions for DeFi-related responses
adamgall
changed the title
Deploying decent-interface with
|
| Latest commit: |
90f91f9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c31ffba8.decent-interface.pages.dev |
| Branch Preview URL: | https://eng-196-defi-positions-fix.decent-interface.pages.dev |
DarksightKellar
approved these changes
Feb 7, 2025
functions/shared/moralisApi.ts
Outdated
| // Handle paginated vs non-paginated responses | ||
| if (isPaginated) { | ||
| const paginatedData = data as MoralisResponse<T>; | ||
| if (!paginatedData || !paginatedData.result) break; |
There was a problem hiding this comment.
In case something weird happens like Moralis changing their API for whatever reason, an error log here before the break would be helpful for faster bug ID'ing. Cz this shouldn't ever happen ideally right?
…efi function - Remove redundant fetchMoralisDefi helper function - Update balances endpoint to use fetchMoralis directly with isPaginated flag - Streamline Moralis API calls for DeFi positions
- Add robust error logging for Moralis API requests - Implement page count limit to prevent infinite pagination - Enhance error handling for unexpected API response structures - Add console warnings and errors for better debugging
Da-Colon
approved these changes
Feb 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/decent-labs/issue/ENG-196/moralis-defi-positions-api-is-currently-broken