ENG-194 Fixed the issue with fetching the DAO info #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/pages/create/SafeCreatePage.tsx
Outdated
| @@ -37,7 +37,7 @@ export function SafeCreatePage() { | |||
| if (daoFound) { | |||
| navigate(DAO_ROUTES.dao.relative(addressPrefix, safeAddress)); | |||
| } else { | |||
| toast.loading(t('failedIndexSafe')); | |||
| toast.warning(t('failedIndexSafe'), { duration: Infinity }); | |||
There was a problem hiding this comment.
My UX concern here is that this isn't a warning per se. It's meant to be more of a re-assuring notice for the user. Suggest you use toast.info instead.
There was a problem hiding this comment.
@johnqh you can do:
toast.loading(t('failedIndexSafe'), { dismissible: true });edit: nevermind, can't dismissible a loading toast.
DarksightKellar
approved these changes
Feb 7, 2025
adamgall
requested changes
Feb 7, 2025
src/pages/create/SafeCreatePage.tsx
Outdated
| @@ -37,7 +37,7 @@ export function SafeCreatePage() { | |||
| if (daoFound) { | |||
| navigate(DAO_ROUTES.dao.relative(addressPrefix, safeAddress)); | |||
| } else { | |||
| toast.loading(t('failedIndexSafe')); | |||
| toast.warning(t('failedIndexSafe'), { duration: Infinity }); | |||
There was a problem hiding this comment.
@johnqh you can do:
toast.loading(t('failedIndexSafe'), { dismissible: true });edit: nevermind, can't dismissible a loading toast.
Deploying decent-interface with
|
| Latest commit: |
78abbb2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://405e1460.decent-interface.pages.dev |
| Branch Preview URL: | https://feature-eng-194-deployed-mes.decent-interface.pages.dev |
adamgall
approved these changes
Feb 7, 2025
Da-Colon
approved these changes
Feb 7, 2025
…sn't work. Changed to info(...). I did test that yesterday.
adamgall
approved these changes
Feb 7, 2025
DarksightKellar
approved these changes
Feb 7, 2025
Da-Colon
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: When a DAO is deployed, 90% of the time we get error retrieving the DAO info because
Fixed: The toast is not dismissible