[ENG-190] Nonce typing from Safe incorrect (develop)
#2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying decent-interface with
|
| Latest commit: |
f56dc49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://401842ca.decent-interface.pages.dev |
| Branch Preview URL: | https://eng-190-multisig-fix.decent-interface.pages.dev |
adamgall
approved these changes
Feb 5, 2025
DarksightKellar
approved these changes
Feb 6, 2025
|
Why this change? |
|
@adamgall I need to rebase this to develop and remove the bump in version. ...Done |
Da-Colon
force-pushed
the
ENG-190-multisig-fix
branch
from
055fda6 to
f56dc49
Compare
Da-Colon
changed the title
[ENG-190] | Hotfix v0.5.2 Nonce typing from Safe incorrect (develop)[ENG-190] Nonce typing from Safe incorrect (develop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-190
Traced the weird conditional failure all the way back to the nonce we receive from Safe's API. The API's
SafeInfoResponsetype for noncenumberbut actually typed astringon the response...Something has changed as of like yesterday?This change is basically causing any
===comparison to fail comparing against the proposal's nonceEdit: Updated the SafeApi SDK to latest reveals this change to
SafeInfoResponse. nonce is indeed a string