[ENG-180 | ENG-182] Unsupported ENS networks
#2709
Conversation
…allback to mainnet if not provided
… if not supported
…et if not supported
…net if not supported
Deploying decent-interface with
|
| Latest commit: |
f884b6c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6250261.decent-interface.pages.dev |
| Branch Preview URL: | https://eng-180-182-ens-error-unsupp.decent-interface.pages.dev |
| let effectiveChainId: number; | ||
| if (props?.chainId !== undefined) { | ||
| if (!supportedEnsNetworks.includes(props.chainId)) { | ||
| throw new Error(`ENS is not supported for chain ${props.chainId}`); |
There was a problem hiding this comment.
This error throwing inside hook's body makes me little nervous - should we just return "nothing" instead? Or the idea is that components / hooks that are using useNetworkEnsAddress are covering underlying usage with some sort of safety gates?
There was a problem hiding this comment.
The error thrown is to alert us. if we use this getENSName inproper case. say we have feature thats pulling info from a third party with a chain id and a address. instead of just defaulting to mainnet silently. this will alert us a problem as it could be unintentional.
That make sense?
| let effectiveChainId: number; | ||
| if (args.chainId !== undefined) { | ||
| if (!supportedEnsNetworks.includes(args.chainId)) { | ||
| throw new Error(`ENS is not supported for chain ${args.chainId}`); |
|
|
||
| if (props?.chainId !== undefined) { | ||
| if (!supportedEnsNetworks.includes(props.chainId)) { | ||
| throw new Error(`ENS is not supported for chain ${props.chainId}`); |
|
Need this work. Merging as we have approvals |
DarksightKellar
deleted the
eng-180-182-ens-error-unsupported-networks
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
sorry @DarksightKellar
Closes ENG-180
Closes ENG-182
@adamgall Called out about the fallback to mainnet, but I pushed back only thinking about the argument
chainIdand protecting against unintentionally setting it to call an unsupported network.Screenshots