[ENG-166]: Fix displaying role's proposal creation permissions

[mudrila]

Changes

• Fix displaying role's proposal creation permissions in view / edit "mode"
• Fix displaying proposal threshold in DAO settings for ERC-721 DAO
• Fix updating / deleting ERC-721 voting strategy when there's existing whitelisting strategy

Issues

• ENG-166

Testing

Pre-setup

1. Create NFT Voting DAO
2. Create couple of roles
3. Grant "Can create proposals" permissions for one role
4. Execute proposal

Proper role's permissions display

1. Navigate to Roles page, open role details -> make sure "Proposals" green badge is displayed
2. Click "Edit Role" -> make sure switch is ON for that role
3. Make sure other roles, which don't have permissions don't have "Proposals" green badge, in "Edit" mode switch should be OFF

Updating proposer threshold / deleting voting strategy

1. Navigate to DAO Settings -> permissions tab
2. Make sure proper proposal threshold is displayed in the card
3. Try editing threshold - make sure new threshold is propagated after proposal execution
4. Try deleting strategy (click trash icon after clicking on "Edit" pencil icon)
5. Make sure strategy is disabled, but you still can create proposals through whitelisted roles

Screenshots

[linear]

ENG-166 Role with create proposals permission has the toggle OFF

[Da-Colon]

Is there bad type safety here? I believe there was type safety conditionals put in place above this component, nominee must be defined.

[mudrila]

Yess - I was getting crash unless I've added this chaining

[Da-Colon]

Approving, but man we have so many in place conditionals.

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ TypeError: Cannot read properties of undefined (reading 'nominee') //roles/edit View Issue

_{Did you find this useful? React with a 👍 or 👎}