Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/eng 161 tokenomisc spelling hotfix #2698

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

johnqh
Copy link
Contributor

@johnqh johnqh commented Jan 30, 2025

Hot fix re-targeting main

Copy link

linear bot commented Jan 30, 2025

Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2025

Deploying decent-interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9c2e7bf
Status: ✅  Deploy successful!
Preview URL: https://0fcc1abc.decent-interface.pages.dev
Branch Preview URL: https://feature-eng-161-tokenomisc-s-el7l.decent-interface.pages.dev

View logs

Da-Colon
Da-Colon previously approved these changes Jan 30, 2025
@Da-Colon Da-Colon dismissed their stale review January 30, 2025 19:33

targeting wrong branch

@johnqh johnqh changed the base branch from develop to main January 30, 2025 19:33
Copy link
Member

@adamgall adamgall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my comment/request from the original PR:

#2693 (review)

(@johnqh I don't think there was a need to close the original PR and open this new one)

@Da-Colon
Copy link
Contributor

Da-Colon commented Jan 30, 2025

Here is my comment from the original PR:

#2693 (review)

+1 oof good thought missed that comment

@johnqh johnqh merged commit c459474 into main Jan 30, 2025
4 checks passed
@adamgall adamgall deleted the feature/ENG-161-Tokenomisc-spelling-hotfix branch January 30, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants