[Eng 137] ENS publicClient async usage updates
#2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mproved network handling
…ith network handling
Deploying decent-interface with
|
| Latest commit: |
bfa2e60
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://920f360f.decent-interface.pages.dev |
| Branch Preview URL: | https://eng-137-ens-updates-publiccl.decent-interface.pages.dev |
…oved consistency and remove public client dependency
Da-Colon
commented
Jan 23, 2025
There was a problem hiding this comment.
I'm wondering, should we be using useEnsName from wagmi at all any more? My gut says no.
| @@ -120,52 +121,50 @@ export function usePrepareFormData() { | |||
| }: AzoriusERC20DAO<BigIntValuePair> & FreezeGuardConfigParam): Promise< | |||
| AzoriusERC20DAO | undefined | |||
| > => { | |||
| if (publicClient) { | |||
There was a problem hiding this comment.
This large section was just me removing this conditional
…move public client dependency
…etworks and improve address resolution logic
Da-Colon
commented
Jan 23, 2025
src/hooks/DAO/useSearchDao.ts
Outdated
Comment on lines
45
to
68
| const { resolvedAddress, isValid } = await resolveENSName(input); | ||
| if (isValid) { | ||
| await findSafes( | ||
| supportedNetworks.map(network => ({ | ||
| address: resolvedAddress, | ||
| chainId: network.chain.id, | ||
| })), | ||
| ); | ||
| } else { | ||
| const resolvedAddresses: Address[] = []; | ||
| for (const chainId of supportedEnsNetworks) { | ||
| const { resolvedAddress, isValid } = await resolveENSName(input, chainId); | ||
| if (isValid) { | ||
| resolvedAddresses.push(resolvedAddress); | ||
| } | ||
| } | ||
| if (resolvedAddresses.length === 0) { | ||
| setErrorMessage('Invalid search'); | ||
| return; | ||
| } | ||
|
|
||
| const resolvedAddressesSet = new Set(resolvedAddresses); | ||
| const mappedAddressesWithChainIds: ResolvedAddressWithChainId[] = []; | ||
| for (const network of supportedNetworks) { | ||
| for (const address of resolvedAddressesSet) { | ||
| mappedAddressesWithChainIds.push({ address, chainId: network.chain.id }); | ||
| } | ||
| } | ||
|
|
||
| await findSafes(mappedAddressesWithChainIds); |
There was a problem hiding this comment.
A little bit of a refactor/update. So now it.
- attempts to resolve the address on supported ENS networks
- creates a Set of unique addresses to prevent repeated requests
- creates an array of addresses with chainIds by looping through supported networks and then the unique addresses to check each of the supported networks for each of the addresses for a safe.
…erface into eng-137-ens-updates-publicClient
…ied chain IDs and throw errors for unsupported chains
…rted ENS networks and enhance public client creation
adamgall
reviewed
Jan 30, 2025
adamgall
reviewed
Jan 30, 2025
There was a problem hiding this comment.
I'm wondering, should we be using useEnsName from wagmi at all any more? My gut says no.
adamgall
requested changes
Jan 30, 2025
…lient creation logic
…plify client creation
- also moved loading state setter to start of
adamgall
approved these changes
Jan 30, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-137.
So as this PR shows we have two different patterns in our app, not saying a bad thing but pointing it out.
We have a
hookpattern, which on component mount the lookup is performed.And updated in this PR, we have the
asyncpattern, where we need to make the call more explicitly either mostly in use in form validation and form submission preparation.This PR brings these 'async' instances to use the same function with the supported ens network used.