-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-113 | Public Client]
Swap wagmi's usePublicClient
with custom client
#2677
Conversation
…ain when a transaction triggered
- removes public !== undefined conditional as its no longer a thing
…ndling to use network configuration
…ooks and components
…ecent-interface into use-walet-client
[ENG-113]
Swap wagmi's usePublicClient
with custom client[ENG-113 | Public Client]
Swap wagmi's usePublicClient
with custom client
… and simplify chain switching logic
…ork configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good ship it
@@ -45,7 +38,7 @@ const useAddress = (addressInput: string) => { | |||
setIsLoading(false); | |||
return; | |||
} | |||
|
|||
// @todo this should be mainnet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at first glance, yes
Deploying decent-interface with
|
Latest commit: |
198330b
|
Status: | ✅ Deploy successful! |
Preview URL: | https://6f7e09f2.decent-interface.pages.dev |
Branch Preview URL: | https://eng-113-swap-usepublicclient.decent-interface.pages.dev |
…ify address validation logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤌🏾
`[ENG-113 | Various]` Other Wagmi Hooks
`[ENG-113 | Wallet-Client]` Swap `useWalletClient` for `useNetworkWalletClient`
Swap out of usePublicClient with
useNetworkPublicClient
which keeps control of what network is interacted with based on the currently set network config.Other Updates
!publicClient
conditionals as no longer the casecreatePublicClient
return (was causing problems otherwise)