Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all contract tests to useMasterCopy #2442

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Nov 1, 2024

  • Includes the COMPLETELY UNUSED (which is probably a bug) linearVotingErc20WrappedMasterCopy contract into our network config.
    • Still not actually using this anywhere, but we probably should. I bet this should be deployed as the strategy when we wrap a user's existing ERC20 token.
  • Re-adds the caching back into useMasterCopy (it's been well over a week since it was disabled, which is the time after which those caches went stale, so it's safe to re-enable them).
  • Remove an unused address property from object returned from getZodiacModuleProxyMasterCopyData function which comes from useMasterCopy hook
  • Add all of the non-singleton contracts to useMasterCopy.
    • Some are already there, but not all. Why, you ask? Probably because there are lots of places in the app where we simply assume that addresses are the contracts that we think they are.
    • This PR doesn't address the above assumptions, but plenty of new PRs are coming which do explicitly check that. We don't ever want to just assume that an address holds the code we expect it to.

@adamgall adamgall self-assigned this Nov 1, 2024
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 8e512a1
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6725517c62807200084517ca
😎 Deploy Preview https://deploy-preview-2442.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall changed the title Master copy identification refactor Add all contract tests to useMasterCopy Nov 2, 2024
@adamgall adamgall merged commit f7f212e into develop Nov 4, 2024
7 checks passed
@adamgall adamgall deleted the master-copy-identification-refactor branch November 4, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants