Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsaved changes stuck state #2400

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix unsaved changes stuck state #2400

merged 2 commits into from
Oct 9, 2024

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Oct 7, 2024

Changes

This PR resets blocker state when saving role form.

Addressed Issues

Testing

  1. Go to editing some role. Change any field.
  2. Click outside of drawer
  3. You should see "Unsaved changes" modal - click "Keep Editing"
  4. Now hit Save button
  5. Verify that changes were saved and you navigated back to roles list.

@mudrila mudrila added the bug Something isn't working label Oct 7, 2024
@mudrila mudrila self-assigned this Oct 7, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 7, 2024 •
edited
Loading

✅ Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 42d501f
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/670433c07f34080008931537
😎 Deploy Preview https://deploy-preview-2400.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Da-Colon
Da-Colon approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wonderful

@mudrila mudrila merged commit e91219b into develop Oct 9, 2024
7 checks passed
@mudrila mudrila deleted the fix/#2395-unsaved-changes-stuck-state branch October 9, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgall adamgall adamgall approved these changes

@Da-Colon Da-Colon Da-Colon approved these changes

@DarksightKellar DarksightKellar Awaiting requested review from DarksightKellar

Assignees

@mudrila mudrila

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsaved Changes weirdness
3 participants
@mudrila @adamgall @Da-Colon