Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams on new hat tree #2343

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Streams on new hat tree #2343

merged 5 commits into from
Sep 13, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Sep 11, 2024

This PR is ready for testing!

Now users are able to create Sablier Payment Streams on new Hats which are being created when no existing Hats Tree exists for the given DAO, which was previously blocked.

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 272da97
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/66e314e1c1e7370008535206
😎 Deploy Preview https://deploy-preview-2343.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mudrila mudrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approving - code-wise looks good, waiting for more changes to come with contracts PR being merged

@adamgall
Copy link
Member Author

adamgall commented Sep 12, 2024

Tentatively approving - code-wise looks good, waiting for more changes to come with contracts PR being merged

FYI the only remaining change will be a bump in the @fractal-framework/fractal-contracts package

edit: bumped

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Approved

@adamgall
Copy link
Member Author

@Da-Colon @mudrila @DarksightKellar any critiques on the code?

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope missed that one comment but the other changes make sense.

@@ -257,6 +330,7 @@ export default function useCreateRoles() {
adminHatId, // adminHatId
hatStruct.details, // details
hatStruct.maxSupply, // maxSupply
// methinks these next two properties can/should be a "dead" (0x0000...4a75) address
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct thats the pattern we saw with others

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2343 (comment)

What I mean is, I'd like to play around with setting these properties to a "dead" address instead of the top hat smart account, and see if changing members still works . I think these should be the dead address.

@adamgall
Copy link
Member Author

Nope missed that one comment but the other changes make sense.

Yeah I think I need to play around with this before merging.

@Da-Colon
Copy link
Contributor

Nope missed that one comment but the other changes make sense.

Yeah I think I need to play around with this before merging.

concerned about a particular change?

@adamgall
Copy link
Member Author

This extra work to minimize the toggle and eligibility module addresses is taking too much time to debug and test. It's not a problem like the way it is now, so let's merge and move on.

@adamgall adamgall merged commit 9197c3b into develop Sep 13, 2024
7 checks passed
@adamgall adamgall deleted the streams-on-new-hat-tree branch September 13, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants