-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streams on new hat tree #2343
Streams on new hat tree #2343
Conversation
…icon when no tooltip exists
…ong with new hat tree
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentatively approving - code-wise looks good, waiting for more changes to come with contracts PR being merged
FYI the only remaining change will be a bump in the edit: bumped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Approved
@Da-Colon @mudrila @DarksightKellar any critiques on the code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope missed that one comment but the other changes make sense.
@@ -257,6 +330,7 @@ export default function useCreateRoles() { | |||
adminHatId, // adminHatId | |||
hatStruct.details, // details | |||
hatStruct.maxSupply, // maxSupply | |||
// methinks these next two properties can/should be a "dead" (0x0000...4a75) address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct thats the pattern we saw with others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean is, I'd like to play around with setting these properties to a "dead" address instead of the top hat smart account, and see if changing members still works . I think these should be the dead address.
Yeah I think I need to play around with this before merging. |
concerned about a particular change? |
This extra work to minimize the |
This PR is ready for testing!
Now users are able to create Sablier Payment Streams on new Hats which are being created when no existing Hats Tree exists for the given DAO, which was previously blocked.