Do not allow clicking(aka editing) soft-deleted roles #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudrila
requested review from
adamgall,
DarksightKellar,
Da-Colon,
nicolaus-sherrill and
xanaramoss
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
approved these changes
Sep 9, 2024
Da-Colon
approved these changes
Sep 9, 2024
DarksightKellar
approved these changes
Sep 9, 2024
adamgall
deleted the
fix/#2292-do-not-allow-editing-soft-deleted-roles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are preventing user from clicking on soft-edited role card / table row.
It is not necessary to redirect user from the soft-edited role details as it is only possible through direct navigation, which will essentially reset form's state.
Closes #2292