Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[roles-0.1.0] - Hook up real data into role details view #2077

Merged
merged 16 commits into from
Jul 5, 2024

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Jul 4, 2024

This PR contains following changes:

  • Show data from the actual hat in RoleDetails, remove mock data usage from there
  • Hide payroll and vesting if data is not present
  • Do not search for Sablier streams if subgraph is not deployed on that network
  • Remove mocks for hats
  • Add mock for vesting
  • Fix predicting hat id
  • Fix adding more hats
  • Remove requirement to being able to add only 2 hats

@mudrila mudrila added bug Something isn't working enhancement New feature or request labels Jul 4, 2024
@mudrila mudrila self-assigned this Jul 4, 2024
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 0e0f491
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/668833ca4b089c0008fdcc98
😎 Deploy Preview https://deploy-preview-2077.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -36,6 +36,16 @@ export default function RoleFormTabs({ hatIndex, save }: { hatIndex: number; sav
),
[values.roleEditing, hatsTree],
);

useEffect(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This useEffect manages going to the specific "Role Edit" page and selecting that role for editing.

// // // // // // // // // // // // // // // // // // // // // // // // //
//
// /!\
// WARNING: UNTESTED AND RADIOACTIVE CODE AHEAD
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and not radioactive anymore 🎉

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I need this code as I duplicated some work with the Mocks, opps. So i'll branch off here.

@mudrila mudrila merged commit 30297cc into roles-0.1.0/root Jul 5, 2024
7 checks passed
@mudrila mudrila deleted the roles-0.1.0/cleanup branch July 5, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants