-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[roles-0.1.0]
- Hook up real data into role details view
#2077
Conversation
…nent and do not show it when there's no payroll data nor vesting data
…aph is not present on a given chain
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -36,6 +36,16 @@ export default function RoleFormTabs({ hatIndex, save }: { hatIndex: number; sav | |||
), | |||
[values.roleEditing, hatsTree], | |||
); | |||
|
|||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This useEffect
manages going to the specific "Role Edit" page and selecting that role for editing.
// // // // // // // // // // // // // // // // // // // // // // // // // | ||
// | ||
// /!\ | ||
// WARNING: UNTESTED AND RADIOACTIVE CODE AHEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and not radioactive anymore 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and I need this code as I duplicated some work with the Mocks, opps. So i'll branch off here.
This PR contains following changes:
hat
inRoleDetails
, remove mock data usage from thereSablier
streams if subgraph is not deployed on that network