Fix proposal count #2074
Merged
Fix proposal count #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng "skipped", to adjust total proposal count
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mudrila
approved these changes
Jul 4, 2024
Da-Colon
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a property to state to track the number of proposals that are being "skipped", to adjust total proposal count.
This is only relevant for our Decent DAO, which has that broken proposal due to malformed Metadata JSON.
We skip that malformed proposal during processing and don't add it to state at all, but a side effect is that our "proposal count" components on the dashboard rely on the Azorius proposal IDs to determine how many have been created (proposal count equals highest ID + 1).
Since we don't want to acknowledge this malformed proposal in our UI, we need to adjust our total proposal count to account for it.