-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree and Hats type sanitization #2060
Tree and Hats type sanitization #2060
Conversation
…fits the shape we care about perfectly
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
interface DecentHat { | ||
id: Hex; | ||
prettyId?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a string of the form "0x0000.aaaa.bbbb.cccc.etc"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolio Looks good to me. I'll take it and adjust my components to work with this new Typing. I like the additional mocking assistance
name?: string; | ||
description?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't include any of our necessary IPFS integration.
When loading in a Hat Tree, sanitize the Hats Tree by making sure it fits the shape we care about perfectly