Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree and Hats type sanitization #2060

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented Jul 1, 2024

When loading in a Hat Tree, sanitize the Hats Tree by making sure it fits the shape we care about perfectly

@adamgall adamgall requested a review from Da-Colon July 1, 2024 21:30
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 7fc3a7e
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6683200b2bc5d80008135f55
😎 Deploy Preview https://deploy-preview-2060.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


interface DecentHat {
id: Hex;
prettyId?: string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a string of the form "0x0000.aaaa.bbbb.cccc.etc"

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio Looks good to me. I'll take it and adjust my components to work with this new Typing. I like the additional mocking assistance

Comment on lines +19 to +20
name?: string;
description?: string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't include any of our necessary IPFS integration.

@adamgall adamgall merged commit b235eeb into issue/2049-add-form Jul 1, 2024
6 of 7 checks passed
@adamgall adamgall deleted the issue/2049-add-form-tree-validation branch July 1, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants