-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to moralis #2027
Migrate to moralis #2027
Conversation
…igrate-to-moralis
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -137,5 +137,6 @@ | |||
"shutterPrivacy": "Shielded", | |||
"shutterVotesHidden": "Results hidden during voting", | |||
"totalVotes": "Total votes", | |||
"clawBackBalancesError": "Failed to process clawback due to unexpected error while retrieving child Safe balances.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolaus-sherrill @tomstuart123 Should child
word be capitalized here?
@@ -33,7 +33,7 @@ | |||
|
|||
- Gnosis Safe, Gnosis, Safe{Wallet}, and the capitalized word Safe are products of [Gnosis](https://gnosis.io/) and should not be translated. | |||
|
|||
- Etherscan, CoinGecko, and ENS (Ethereum Name Service) are additional web3 products that are mentioned, and should not be translated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bye bye CoinGecko, hello Moralis ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments.
# Minutes to cache prices for token addresses | ||
TOKEN_PRICE_CACHE_INTERVAL_MINUTES="" | ||
# Minutes to cache token balances for address | ||
BALANCES_CACHE_INTERVAL_MINUTES="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a default you suggest for this value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For local development - whatever is reasonable when you're interacting / working with treasury and need more frequent updates.
For remote dev - I'm not sure, guess it's more product question. @tomstuart123 @nicolaus-sherrill How do you think, for how long we should be caching Safe Treasury balances?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code approved, Haven't live tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Belated LGTM!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
No description provided.