Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to moralis #2027

Merged

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Jun 19, 2024

No description provided.

@mudrila mudrila added enhancement New feature or request maintenance Keep the lights on labels Jun 19, 2024
@mudrila mudrila self-assigned this Jun 19, 2024
Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit c333cb9
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6679d5055a6ddb0008315242
😎 Deploy Preview https://deploy-preview-2027.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -137,5 +137,6 @@
"shutterPrivacy": "Shielded",
"shutterVotesHidden": "Results hidden during voting",
"totalVotes": "Total votes",
"clawBackBalancesError": "Failed to process clawback due to unexpected error while retrieving child Safe balances.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolaus-sherrill @tomstuart123 Should child word be capitalized here?

@@ -33,7 +33,7 @@

- Gnosis Safe, Gnosis, Safe{Wallet}, and the capitalized word Safe are products of [Gnosis](https://gnosis.io/) and should not be translated.

- Etherscan, CoinGecko, and ENS (Ethereum Name Service) are additional web3 products that are mentioned, and should not be translated.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye CoinGecko, hello Moralis ❤️

Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments.

# Minutes to cache prices for token addresses
TOKEN_PRICE_CACHE_INTERVAL_MINUTES=""
# Minutes to cache token balances for address
BALANCES_CACHE_INTERVAL_MINUTES=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a default you suggest for this value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For local development - whatever is reasonable when you're interacting / working with treasury and need more frequent updates.
For remote dev - I'm not sure, guess it's more product question. @tomstuart123 @nicolaus-sherrill How do you think, for how long we should be caching Safe Treasury balances?

@mudrila mudrila requested a review from Da-Colon June 24, 2024 17:08
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code approved, Haven't live tested.

@mudrila mudrila merged commit b3a49b3 into maintenance/migrate-to-safe-api-sdk Jun 25, 2024
7 checks passed
@mudrila mudrila deleted the maintenance/migrate-to-moralis branch June 25, 2024 15:32
Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated LGTM!

Copy link

sentry-io bot commented Jun 28, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to fetch //home View Issue
  • ‼️ TypeError: Failed to fetch //home View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Keep the lights on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants