Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typechain cleanup 14 #2015

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

adamgall
Copy link
Member

Depends on #2014

  • Remove getAddress from a few more files
  • Remove more instances of getAddress
  • Let Avatar props be Address type

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 4f6555f
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/66719f100b7e0c00083d53bc
😎 Deploy Preview https://deploy-preview-2015.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall force-pushed the remove-typechain-cleanup-13 branch from fc3d07b to 25128e5 Compare June 14, 2024 18:07
@adamgall adamgall force-pushed the remove-typechain-cleanup-14 branch from b4d5bd1 to 3f49106 Compare June 14, 2024 18:07
@adamgall adamgall force-pushed the remove-typechain-cleanup-13 branch from 25128e5 to d6ab077 Compare June 15, 2024 05:43
@adamgall adamgall force-pushed the remove-typechain-cleanup-14 branch from 3f49106 to a4775f3 Compare June 15, 2024 05:44
@@ -64,7 +65,7 @@ function ProposalAuthor({ activity }: { activity: Activity }) {
>
<Avatar
size="sm"
address={proposer}
address={getAddress(proposer)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'd expect proposer at this stage already being Address...

@adamgall adamgall force-pushed the remove-typechain-cleanup-13 branch from d6ab077 to 5279e41 Compare June 15, 2024 18:42
@adamgall adamgall force-pushed the remove-typechain-cleanup-14 branch from a4775f3 to 3e9a2b6 Compare June 15, 2024 18:42
@adamgall adamgall force-pushed the remove-typechain-cleanup-13 branch from 5279e41 to 4daccd8 Compare June 15, 2024 23:24
@adamgall adamgall force-pushed the remove-typechain-cleanup-14 branch from 3e9a2b6 to 28df1db Compare June 15, 2024 23:24
@adamgall adamgall force-pushed the remove-typechain-cleanup-13 branch from 4daccd8 to 802fcc8 Compare June 17, 2024 01:41
@adamgall adamgall force-pushed the remove-typechain-cleanup-14 branch from 28df1db to 3ddde26 Compare June 17, 2024 01:46
@adamgall adamgall force-pushed the remove-typechain-cleanup-13 branch from 802fcc8 to 24c7e8a Compare June 17, 2024 22:33
@adamgall adamgall force-pushed the remove-typechain-cleanup-14 branch from 3ddde26 to ac41189 Compare June 17, 2024 22:33
@adamgall adamgall force-pushed the remove-typechain-cleanup-13 branch from 24c7e8a to bf8de8d Compare June 18, 2024 03:35
@adamgall adamgall force-pushed the remove-typechain-cleanup-14 branch from ac41189 to c9a4198 Compare June 18, 2024 03:35
@adamgall adamgall force-pushed the remove-typechain-cleanup-13 branch from bf8de8d to ab2477e Compare June 18, 2024 04:02
@adamgall adamgall force-pushed the remove-typechain-cleanup-14 branch from c9a4198 to fbcfea5 Compare June 18, 2024 04:02
@adamgall adamgall marked this pull request as ready for review June 18, 2024 04:03
@adamgall adamgall force-pushed the remove-typechain-cleanup-13 branch from ab2477e to 0e4c60b Compare June 18, 2024 13:20
@adamgall adamgall force-pushed the remove-typechain-cleanup-14 branch from fbcfea5 to 3ecb8e3 Compare June 18, 2024 13:20
@adamgall adamgall force-pushed the remove-typechain-cleanup-13 branch from 0e4c60b to fcfc9d6 Compare June 18, 2024 14:48
Base automatically changed from remove-typechain-cleanup-13 to root/remove-typechain June 18, 2024 14:51
@adamgall adamgall force-pushed the remove-typechain-cleanup-14 branch from 3ecb8e3 to 4f6555f Compare June 18, 2024 14:51
@adamgall adamgall merged commit 418cfc7 into root/remove-typechain Jun 18, 2024
7 checks passed
@adamgall adamgall deleted the remove-typechain-cleanup-14 branch June 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants