Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove typechain cleanup 3 #2004

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Remove typechain cleanup 3 #2004

merged 2 commits into from
Jun 17, 2024

Conversation

adamgall
Copy link
Member

Depends on #2003

  • Remove unused contractCall function from useTransaction
  • Rename contractCallViem to contractCall and reorder return properties of useTransaction

@adamgall adamgall self-assigned this Jun 13, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 13, 2024 •
edited
Loading

✅ Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit c224295
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/666f8de32bd7af000875eb20
😎 Deploy Preview https://deploy-preview-2004.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall mentioned this pull request Jun 13, 2024
Merged
mudrila
mudrila approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@mudrila mudrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@adamgall adamgall force-pushed the remove-typechain-cleanup-2 branch from a46108a to ae9dcc7 Compare June 15, 2024 18:15
@adamgall adamgall force-pushed the remove-typechain-cleanup-3 branch from 572ba9f to c87d1f7 Compare June 15, 2024 18:16
@adamgall adamgall force-pushed the remove-typechain-cleanup-2 branch from ae9dcc7 to 5e3e318 Compare June 15, 2024 23:23
@adamgall adamgall force-pushed the remove-typechain-cleanup-3 branch from c87d1f7 to f23ca85 Compare June 15, 2024 23:23
Da-Colon
Da-Colon approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@adamgall adamgall force-pushed the remove-typechain-cleanup-2 branch from 5e3e318 to 15dd9fb Compare June 17, 2024 01:10
Base automatically changed from remove-typechain-cleanup-2 to root/remove-typechain June 17, 2024 01:13
@adamgall adamgall force-pushed the remove-typechain-cleanup-3 branch from f23ca85 to c224295 Compare June 17, 2024 01:14
@adamgall adamgall marked this pull request as ready for review June 17, 2024 01:14
@adamgall adamgall merged commit ce4dc84 into root/remove-typechain Jun 17, 2024
7 checks passed
@adamgall adamgall deleted the remove-typechain-cleanup-3 branch June 17, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudrila mudrila mudrila approved these changes

@Da-Colon Da-Colon Da-Colon approved these changes

@DarksightKellar DarksightKellar Awaiting requested review from DarksightKellar

Assignees

@adamgall adamgall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamgall @mudrila @Da-Colon