Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smol update #1840

Merged
merged 4 commits into from
May 21, 2024
Merged

Smol update #1840

merged 4 commits into from
May 21, 2024

Conversation

adamgall
Copy link
Member

  • Remove instances of VITE_APP_TESTING_ENVIRONMENT because we don't do that anymore
  • Use a bigger icon in wagmi metadata for wallet connect and coinbase wallet and things like that

@adamgall adamgall self-assigned this May 20, 2024
@netlify Netlify
Copy link

netlify bot commented May 20, 2024 •
edited
Loading

✅ Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit 20e9f08
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/664ca10316ed27000846e267
😎 Deploy Preview https://deploy-preview-1840.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Da-Colon
Da-Colon approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You do have two lint warnings in Github

@adamgall
Copy link
Member Author

adamgall commented May 21, 2024 •
edited
Loading

LGTM. You do have two lint warnings in Github

Ah, good call @Da-Colon! And that actually led to a bit more smol cleanup!

@adamgall adamgall merged commit beb3e96 into develop May 21, 2024
7 checks passed
@adamgall adamgall deleted the smol-update branch May 21, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Da-Colon Da-Colon Da-Colon approved these changes

@DarksightKellar DarksightKellar Awaiting requested review from DarksightKellar

@mudrila mudrila Awaiting requested review from mudrila

Assignees

@adamgall adamgall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamgall @Da-Colon