-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reskin
Moves ProposalCountdown from the Badge component
#1786
Reskin
Moves ProposalCountdown from the Badge component
#1786
Conversation
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can cleanup the props to ProposalCountdown
a bit.
At first glance, textStyle
will _alwaysbe
label-base`, so can probably remove it and inline the style.
The showIcon
prop is only true
in one usage of this component... Do we really need it?
Etc.
36c0e50
to
2ad58aa
Compare
Updated to remove the textStyle. But the other two props These defaults seem to mainly be for the the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove icons logic pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reskin
Moves ProposalCountdown from the Badge component
To @Da-Colon's point, The "logo" discussion doesn't have anything to do with countdown timer for active proposal and the "Active" chip. sorry for derailing this PR. |
tested for both vote period and timelock. both work really well Thanks @Da-Colon (note I did find an issue but not related to this PR) |
Separate the
ProposalCountdown
from theBadge
componentFixes #1695