feat: add party size support & misc #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead8309
reviewed
Oct 11, 2024
dead8309
reviewed
Oct 11, 2024
feature_logs/src/main/java/com/my/kizzy/feature_logs/LogsViewModel.kt
Outdated
Show resolved
Hide resolved
dead8309
reviewed
Oct 11, 2024
dead8309
reviewed
Oct 11, 2024
dead8309
reviewed
Oct 11, 2024
kyrie25
force-pushed
the
party_size_localization
branch
from
1712df9 to
61e8fde
Compare
dead8309
reviewed
Oct 11, 2024
feature_custom_rpc/src/main/java/com/my/kizzy/feature_custom_rpc/CustomRpc.kt
Outdated
Show resolved
Hide resolved
kyrie25
force-pushed
the
party_size_localization
branch
from
52fe2c8 to
0ab13d4
Compare
dead8309
approved these changes
Oct 11, 2024
|
Thanks for your contribution! In the future, I'd recommend opening smaller PRs to make it easier for me to review quickly 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPC tends to get stuck for hours on end as long as the media session is still active, plus it would also prevent app detection on Experimental RPC for the same reason
It is near impossible to read logs with an RPC service active
Placeholder message for activity status was also confusing as, if you need the user to enter a specific string in it, the string needs to be put inside quotation marks, e.g.
online->"online"