Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't install extra directories #1183

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Don't install extra directories #1183

merged 1 commit into from
Dec 12, 2024

Conversation

parona-source
Copy link
Contributor

@parona-source parona-source commented Dec 12, 2024 •
edited
Loading

Description

pyproject.toml has a typo for test and doesnt explicitly exclude doc. Meaning both get installed to site-packages. Instead of explicitly listing these, I just included mycli on its own.

Before:

unzip -l ../mycli_wheels/mycli-1.27.2.dev60+ga206b1d-py3-none-any.whl 
Archive:  ../mycli_wheels/mycli-1.27.2.dev60+ga206b1d-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
     1167  12-12-2024 06:37   doc/key_bindings.rst
     1755  12-12-2024 06:37   mycli/AUTHORS
      484  07-27-2023 11:49   mycli/SPONSORS
       77  12-12-2024 06:37   mycli/__init__.py
     1532  12-12-2024 06:37   mycli/clibuffer.py
     6153  12-12-2024 06:37   mycli/clistyle.py
     1857  12-12-2024 06:37   mycli/clitoolbar.py
      113  12-12-2024 06:37   mycli/compat.py
     5133  12-12-2024 06:37   mycli/completion_refresher.py
    10062  12-12-2024 06:37   mycli/config.py
     4551  12-12-2024 06:37   mycli/key_bindings.py
      293  12-12-2024 06:37   mycli/lexer.py
     2058  12-12-2024 06:37   mycli/magic.py
    57039  12-12-2024 06:37   mycli/main.py
     5297  12-12-2024 06:37   mycli/myclirc
    32518  12-12-2024 06:37   mycli/sqlcompleter.py
    15031  12-12-2024 06:37   mycli/sqlexecute.py
        0  07-27-2023 11:49   mycli/packages/__init__.py
    12225  12-12-2024 06:37   mycli/packages/completion_engine.py
     2853  12-12-2024 06:37   mycli/packages/filepaths.py
     9565  12-12-2024 06:37   mycli/packages/parseutils.py
     1520  12-12-2024 06:37   mycli/packages/prompt_utils.py
      805  12-12-2024 06:37   mycli/packages/paramiko_stub/__init__.py
      285  12-12-2024 06:37   mycli/packages/special/__init__.py
     5405  12-12-2024 06:37   mycli/packages/special/dbcommands.py
     2626  12-12-2024 06:37   mycli/packages/special/delimitercommand.py
     2160  12-12-2024 06:37   mycli/packages/special/favoritequeries.py
    15816  12-12-2024 06:37   mycli/packages/special/iocommands.py
     3981  12-12-2024 06:37   mycli/packages/special/main.py
     1442  12-12-2024 06:37   mycli/packages/special/utils.py
        0  12-12-2024 06:20   mycli/packages/tabular_output/__init__.py
     2017  12-12-2024 06:37   mycli/packages/tabular_output/sql_format.py
        0  12-12-2024 06:37   mycli/packages/toolkit/__init__.py
     1536  12-12-2024 06:37   mycli/packages/toolkit/fzf.py
     1686  12-12-2024 06:37   mycli/packages/toolkit/history.py
        0  12-12-2024 06:20   test/__init__.py
      864  12-12-2024 06:37   test/conftest.py
     5346  12-12-2024 06:37   test/myclirc
      156  07-27-2023 11:49   test/mylogin.cnf
       13  07-27-2023 11:49   test/test.txt
      837  12-12-2024 06:37   test/test_clistyle.py
    20214  12-12-2024 06:37   test/test_completion_engine.py
     2446  12-12-2024 06:37   test/test_completion_refresher.py
     5862  12-12-2024 06:37   test/test_config.py
     1192  12-12-2024 06:37   test/test_dbspecial.py
    17624  12-12-2024 06:37   test/test_main.py
     1812  12-12-2024 06:37   test/test_naive_completion.py
     5639  12-12-2024 06:37   test/test_parseutils.py
     1550  07-27-2023 11:49   test/test_plan.wiki
      286  12-12-2024 06:37   test/test_prompt_utils.py
    13948  12-12-2024 06:37   test/test_smart_completion_public_schema_only.py
    11563  12-12-2024 06:37   test/test_special_iocommands.py
    10408  12-12-2024 06:37   test/test_sqlexecute.py
     4127  12-12-2024 06:37   test/test_tabular_output.py
     2450  12-12-2024 06:37   test/utils.py
        0  08-12-2023 03:25   test/features/__init__.py
      407  07-27-2023 11:49   test/features/auto_vertical.feature
      447  12-12-2024 06:20   test/features/basic_commands.feature
     1201  12-12-2024 06:20   test/features/connection.feature
     1022  12-12-2024 06:20   test/features/crud_database.feature
     1721  12-12-2024 06:20   test/features/crud_table.feature
     1764  12-12-2024 06:37   test/features/db_utils.py
     5093  12-12-2024 06:37   test/features/environment.py
      701  12-12-2024 06:37   test/features/fixture_utils.py
     1449  12-12-2024 06:20   test/features/iocommands.feature
     1007  12-12-2024 06:20   test/features/named_queries.feature
      174  07-27-2023 11:49   test/features/specials.feature
      272  07-27-2023 11:49   test/features/wrappager.py
     1848  07-27-2023 11:49   test/features/fixture_data/help.txt
     3317  12-12-2024 06:20   test/features/fixture_data/help_commands.txt
        0  07-27-2023 11:49   test/features/steps/__init__.py
     1289  12-12-2024 06:37   test/features/steps/auto_vertical.py
     2930  12-12-2024 06:37   test/features/steps/basic_commands.py
     1931  12-12-2024 06:37   test/features/steps/connection.py
     3292  12-12-2024 06:37   test/features/steps/crud_database.py
     3013  12-12-2024 06:37   test/features/steps/crud_table.py
     3013  12-12-2024 06:37   test/features/steps/iocommands.py
     2849  12-12-2024 06:37   test/features/steps/named_queries.py
      748  12-12-2024 06:37   test/features/steps/specials.py
      282  12-12-2024 06:37   test/features/steps/utils.py
     3242  12-12-2024 06:37   test/features/steps/wrappers.py
       54  12-12-2024 06:38   mycli-1.27.2.dev60+ga206b1d.dist-info/AUTHORS.rst
     1761  12-12-2024 06:38   mycli-1.27.2.dev60+ga206b1d.dist-info/LICENSE.txt
     9581  12-12-2024 06:38   mycli-1.27.2.dev60+ga206b1d.dist-info/METADATA
       91  12-12-2024 06:38   mycli-1.27.2.dev60+ga206b1d.dist-info/WHEEL
       41  12-12-2024 06:38   mycli-1.27.2.dev60+ga206b1d.dist-info/entry_points.txt
       20  12-12-2024 06:38   mycli-1.27.2.dev60+ga206b1d.dist-info/top_level.txt
     7469  12-12-2024 06:38   mycli-1.27.2.dev60+ga206b1d.dist-info/RECORD
---------                     -------
   377408                     88 files

After:

$ unzip -l dist/mycli-1.27.2.dev61+gd504621-py3-none-any.whl 
Archive:  dist/mycli-1.27.2.dev61+gd504621-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
     1755  12-12-2024 06:37   mycli/AUTHORS
      484  07-27-2023 11:49   mycli/SPONSORS
       77  12-12-2024 06:37   mycli/__init__.py
     1532  12-12-2024 06:37   mycli/clibuffer.py
     6153  12-12-2024 06:37   mycli/clistyle.py
     1857  12-12-2024 06:37   mycli/clitoolbar.py
      113  12-12-2024 06:37   mycli/compat.py
     5133  12-12-2024 06:37   mycli/completion_refresher.py
    10062  12-12-2024 06:37   mycli/config.py
     4551  12-12-2024 06:37   mycli/key_bindings.py
      293  12-12-2024 06:37   mycli/lexer.py
     2058  12-12-2024 06:37   mycli/magic.py
    57039  12-12-2024 06:37   mycli/main.py
     5297  12-12-2024 06:37   mycli/myclirc
    32518  12-12-2024 06:37   mycli/sqlcompleter.py
    15031  12-12-2024 06:37   mycli/sqlexecute.py
        0  07-27-2023 11:49   mycli/packages/__init__.py
    12225  12-12-2024 06:37   mycli/packages/completion_engine.py
     2853  12-12-2024 06:37   mycli/packages/filepaths.py
     9565  12-12-2024 06:37   mycli/packages/parseutils.py
     1520  12-12-2024 06:37   mycli/packages/prompt_utils.py
      805  12-12-2024 06:37   mycli/packages/paramiko_stub/__init__.py
      285  12-12-2024 06:37   mycli/packages/special/__init__.py
     5405  12-12-2024 06:37   mycli/packages/special/dbcommands.py
     2626  12-12-2024 06:37   mycli/packages/special/delimitercommand.py
     2160  12-12-2024 06:37   mycli/packages/special/favoritequeries.py
    15816  12-12-2024 06:37   mycli/packages/special/iocommands.py
     3981  12-12-2024 06:37   mycli/packages/special/main.py
     1442  12-12-2024 06:37   mycli/packages/special/utils.py
        0  12-12-2024 06:20   mycli/packages/tabular_output/__init__.py
     2017  12-12-2024 06:37   mycli/packages/tabular_output/sql_format.py
        0  12-12-2024 06:37   mycli/packages/toolkit/__init__.py
     1536  12-12-2024 06:37   mycli/packages/toolkit/fzf.py
     1686  12-12-2024 06:37   mycli/packages/toolkit/history.py
       54  12-12-2024 07:09   mycli-1.27.2.dev61+gd504621.dist-info/AUTHORS.rst
     1761  12-12-2024 07:09   mycli-1.27.2.dev61+gd504621.dist-info/LICENSE.txt
     9581  12-12-2024 07:09   mycli-1.27.2.dev61+gd504621.dist-info/METADATA
       91  12-12-2024 07:09   mycli-1.27.2.dev61+gd504621.dist-info/WHEEL
       41  12-12-2024 07:09   mycli-1.27.2.dev61+gd504621.dist-info/entry_points.txt
        6  12-12-2024 07:09   mycli-1.27.2.dev61+gd504621.dist-info/top_level.txt
     3488  12-12-2024 07:09   mycli-1.27.2.dev61+gd504621.dist-info/RECORD
---------                     -------
   222897                     41 files

Checklist

  • I've added this contribution to the changelog.md.
  • I've added my name to the AUTHORS file (or it's already there).

@parona-source parona-source marked this pull request as draft December 12, 2024 06:53
@parona-source parona-source changed the title Fix typo which leads to tests getting installed again Fix typo which leads to tests getting installed again + Don't install the doc directory Dec 12, 2024
@parona-source parona-source marked this pull request as ready for review December 12, 2024 06:55
@parona-source parona-source changed the title Fix typo which leads to tests getting installed again + Don't install the doc directory Don't install extra directories Dec 12, 2024
@parona-source
Include mycli instead of excluding each directory separately
d504621 
Signed-off-by: Alfred Wingate <parona@protonmail.com>
@amjith
Copy link
Member

amjith commented Dec 12, 2024

Thank you!

@amjith amjith merged commit 23b4212 into dbcli:main Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amjith amjith amjith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parona-source @amjith