Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when required flag is missing #33

Merged
merged 1 commit into from
Oct 20, 2018
Merged

Return error when required flag is missing #33

merged 1 commit into from
Oct 20, 2018

Conversation

condemil
Copy link
Contributor

Fixes #31

@codecov-io
Copy link

codecov-io commented Oct 20, 2018

Codecov Report

Merging #33 into master will decrease coverage by 0.98%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   65.37%   64.39%   -0.99%     
==========================================
  Files           4        4              
  Lines         335      337       +2     
==========================================
- Hits          219      217       -2     
- Misses         82       87       +5     
+ Partials       34       33       -1
Impacted Files Coverage Δ
cli/cli.go 82.71% <57.89%> (-4.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655fff6...fae8be2. Read the comment docs.

@davrodpin
Copy link
Owner

Thanks for contributing to the project, @condemil!

Please rebase with master so I can approve it.

@condemil
Copy link
Contributor Author

Rebased

@davrodpin davrodpin merged commit 7cc53ef into davrodpin:master Oct 20, 2018
@davrodpin
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants