Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow for creating msi for qsv #1009

Merged
merged 1 commit into from
Jun 1, 2023
Merged

workflow for creating msi for qsv #1009

merged 1 commit into from
Jun 1, 2023

Conversation

minhajuddin2510
Copy link
Collaborator

@minhajuddin2510 minhajuddin2510 commented Jun 1, 2023 •
edited
Loading

Please review @jqnatividad

jqnatividad
jqnatividad approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@jqnatividad jqnatividad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires a few tweaks but LGTM.

Will do the tweaks after merging, as that is the only way to really test it in GH Actions.

@jqnatividad jqnatividad merged commit a3125b9 into master Jun 1, 2023
@p-linnane p-linnane mentioned this pull request Jun 7, 2023
Merged
@jqnatividad jqnatividad deleted the workflow-for-creating-msi-for-qsv branch June 14, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jqnatividad jqnatividad jqnatividad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minhajuddin2510 @jqnatividad