Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qsvpdp-unknown-linux-musl is missing commands? #2064

Closed
Dialga opened this issue Aug 18, 2024 · 3 comments
Closed

qsvpdp-unknown-linux-musl is missing commands? #2064

Dialga opened this issue Aug 18, 2024 · 3 comments
Labels
wontfix This will not be worked on works as designed

Comments

@Dialga
Copy link

Dialga commented Aug 18, 2024

Describe the bug
qsvpdp is missing the sqlp, luau, joinp commands

To Reproduce
Steps to reproduce the behavior:
As above.

Expected behavior
The unknown-linux-musl build to include the datapusher commands.

Screenshots/Backtrace/Sample Data
If applicable, add screenshots/backtraces/sample data to help explain your problem.

Desktop (please complete the following information):

  • OS: Arch Linux
  • qsv Version 0.131.1

Additional context

@jqnatividad
Copy link
Collaborator

jqnatividad commented Aug 18, 2024

Last time I tried, luau would not cross-compile in the unknown-linux-musl platform and sqlp and joinp are not included in the qsvdp variants by design given how big they'll make the binary.

Also, in the current version, all the commands you cited are not used by DP+.

Regardless, you are free to specify an alternate qsv variant with DP+, even the full qsv prebuilt variant, by changing its configuration section in the CKAN ini file.

Alternatively, if you're using the prebuilt binaries, you may want to install or compile from source using Arch Linux instead, to get a qsvpdp variant that works in Arch Linux.

As we use GitHub's action runners to create the prebuilts, the musl targets have to be cross-compiled as there are no native unknown-linux-musl action runners, and there are certain limitations when cross-compiling with Rust that forced me to exclude luau from the musl prebuilts.

I could have created a self-hosted, unknown-linux-musl action runner (as I did with Apple Silicon), but I do not have machines that run using that platform as we primarily target the latest Ubuntu LTS on x86_64-unknown-linux-gnu for all our work.

@jqnatividad jqnatividad added works as designed wontfix This will not be worked on labels Aug 18, 2024
@Dialga
Copy link
Author

Dialga commented Aug 19, 2024

Hi thanks for your response, if this is a limitation with github's actions then a paragraph in the readme would be suffice to close this issue. I only bought it up here after downloading the musl target and finding out the luau and sqlp commands were missing from qsv, unsure whether it was omitted by accident or to reduce the binary size.

@jqnatividad
Copy link
Collaborator

@Dialga , I added the note as you suggested.

Feel free to open a PR to further wordsmith the note if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on works as designed
Projects
None yet
Development

No branches or pull requests

2 participants