Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor stats caching and eliminate binary format #2040

Closed
jqnatividad opened this issue Aug 9, 2024 · 0 comments · Fixed by #2055
Closed

Refactor stats caching and eliminate binary format #2040

jqnatividad opened this issue Aug 9, 2024 · 0 comments · Fixed by #2055
Assignees
Labels
bug Something isn't working enhancement New feature or request. Once marked with this label, its in the backlog. performance

Comments

@jqnatividad
Copy link
Collaborator

When the stats cache was first implemented, we created a binary format of the stats in addition to the CSV cache, with the --stats-binout option.

This was an attempt to directly load the stats into memory, directly into the Stats data structure and eliminate parsing.

However, it seems the decompression/direct-load approach actually takes a long time. Even longer than parsing the CSV file!

For "automagical" commands that uses Stats caches, we should just parse the human-readable CSV version of the cache, and eliminate the binary format.

@jqnatividad jqnatividad added enhancement New feature or request. Once marked with this label, its in the backlog. performance bug Something isn't working labels Aug 9, 2024
@jqnatividad jqnatividad self-assigned this Aug 11, 2024
@jqnatividad jqnatividad added the WIP work in progress label Aug 11, 2024
jqnatividad added a commit that referenced this issue Aug 16, 2024
…ode` default to `auto`

now that #2040 has been fixed
@jqnatividad jqnatividad removed the WIP work in progress label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request. Once marked with this label, its in the backlog. performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant