Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describegpt: add a --prompt-file option #1085

Closed
jqnatividad opened this issue Jun 29, 2023 · 3 comments · Fixed by #1120
Closed

describegpt: add a --prompt-file option #1085

jqnatividad opened this issue Jun 29, 2023 · 3 comments · Fixed by #1120
Assignees
Labels
enhancement New feature or request. Once marked with this label, its in the backlog.

Comments

@jqnatividad
Copy link
Collaborator

The prompt file is a json file specifying the dictionary prompt, description prompt and the tags prompt to use.

If specified, it will load the prompts from the json file instead of using the default prompts.

@rzmk
Copy link
Collaborator

rzmk commented Jul 3, 2023

@jqnatividad Is there a default format that's expected for the prompt file? For example:

{
    "dictionary_prompt": "...",
    "description_prompt": "...",
    "tags_prompt": "..."
}

We can then check if the --prompt-file option and relevant inference option(s) are used are used, and if they exist in the file to run them.

Also should we specify that prompt file format anywhere?

@jqnatividad
Copy link
Collaborator Author

@rzmk , add some metadata attributes:

{
  "name": "...",
  "description": "...",
  "author": "...",
  "version": "...",
  "tokens": 10,
  "dictionary_prompt": "...",
  "description_prompt": "..",
  "tags_promt": "..."
}

the tokens attribute will be used unless --max-tokens option is set explicitly when invoking describegpt.

As for specifying the --prompt-file format. document it in the docs directory, similar to how fetch has its own markdown file there.

@rzmk
Copy link
Collaborator

rzmk commented Jul 5, 2023

@jqnatividad How should we identify where to input the stats, frequency, and json_add string within these prompts?

If we can do this then we could consider moving the current prompt functions into a default prompt file.

jqnatividad added a commit that referenced this issue Jul 11, 2023
describegpt: add --prompt-file option (resolves #1085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. Once marked with this label, its in the backlog.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants