Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for templatable keys #3

Merged
merged 1 commit into from
Nov 10, 2016
Merged

Conversation

t00f
Copy link

@t00f t00f commented Nov 9, 2016

This PR is intended to fix Enable templating for keys #2.

  • Added 2 new tests that verifies:
    • Template keys
    • Template keys with default value
  • Call parse on the key and the value in case of an object

Copy link
Member

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t00f Awesome work! Thanks for this.

@@ -86,18 +86,18 @@ function parseObject(object){

var children = Object.keys(object).map(function (key){
return {
key: key,
template: parse(object[key])
keyTemplate: parse(key),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@curran curran merged commit a435d75 into datavis-tech:master Nov 10, 2016
@curran curran mentioned this pull request Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants