Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pascal case permissions #353

Merged
merged 2 commits into from
May 15, 2024
Merged

Pascal case permissions #353

merged 2 commits into from
May 15, 2024

Conversation

sctmike
Copy link
Contributor

@sctmike sctmike commented May 14, 2024

using camelCase permission strings result in the error Unrecognized permission read

@nblumhardt
Copy link
Member

Thanks for the PR, @sctmike!

I think the intention is that permission names are treated in a case-insensitive manner; along with this doc change (which will help people on the current version), are you open to changing the Enum.TryParse call in ApiKey.CreateCommand pass the ignoreCase flag also?

@sctmike
Copy link
Contributor Author

sctmike commented May 15, 2024

Thanks for the PR, @sctmike!

I think the intention is that permission names are treated in a case-insensitive manner; along with this doc change (which will help people on the current version), are you open to changing the Enum.TryParse call in ApiKey.CreateCommand pass the ignoreCase flag also?

sure thing, done

@nblumhardt nblumhardt merged commit b62577b into datalust:dev May 15, 2024
1 check passed
@nblumhardt
Copy link
Member

Thanks very much, Mike 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants