Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BF] Small fixes to latest cli commands #333

Merged
merged 2 commits into from
Sep 1, 2023
Merged

[BF] Small fixes to latest cli commands #333

merged 2 commits into from
Sep 1, 2023

Conversation

jsheunis
Copy link
Member

@jsheunis jsheunis commented Sep 1, 2023

Just a couple of basic fixes and additional tests to fix issues that @mslw encountered during usage

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (ae17248) 86.14% compared to head (e0d7c28) 86.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   86.14%   86.19%   +0.04%     
==========================================
  Files          43       43              
  Lines        2700     2709       +9     
==========================================
+ Hits         2326     2335       +9     
  Misses        374      374              
Flag Coverage Δ
unittests 79.07% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
datalad_catalog/set.py 100.00% <100.00%> (ø)
datalad_catalog/tests/test_set.py 100.00% <100.00%> (ø)
datalad_catalog/tests/test_validate.py 100.00% <100.00%> (ø)
datalad_catalog/validate.py 93.54% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsheunis jsheunis merged commit d6efc34 into main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catalog_set yields both "ok" and "impossible" Validate won't work without a dataset
2 participants