Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create script to generate topic cache from mcf. #4775

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

keyurva
Copy link
Contributor

@keyurva keyurva commented Dec 6, 2024

  • The MCF is the latest MCF provided by the UN.
  • The topic cache json and sentence CSV are generated by the script.

@keyurva keyurva requested a review from dwnoble December 6, 2024 18:25
Copy link
Contributor

@dwnoble dwnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Keyur!

Can you remove the sheets_svs.csv file? I think it does have some issues so i'd rather keep the oder version that we know produces a good topic cache output

@keyurva
Copy link
Contributor Author

keyurva commented Dec 6, 2024

The old one is the one that will continue to be used. The sheets_svs.csv that will be used is this one: /~https://github.com/datacommonsorg/website/blob/732f6da6d568e2efd8e7e210796b818b10980163/tools/nl/embeddings/input/sdg/sheets_svs.csv and not the one from this PR. It will need to be copied to the embeddings directory if it were to be used.

Copy link
Contributor

@dwnoble dwnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it-that makes sense.

Thanks keyur!

@keyurva keyurva merged commit 4aeefc3 into datacommonsorg:master Dec 9, 2024
9 checks passed
@keyurva keyurva deleted the sdg branch December 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants