Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IntervalsDF #256

Merged
merged 38 commits into from
Sep 22, 2022
Merged

Add IntervalsDF #256

merged 38 commits into from
Sep 22, 2022

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Sep 14, 2022

Fixes #247

Summary of changes:

  • Adds IntervalsDF class in tempo.intervals to assist with working DataFrames containing records that represent snapshots of the state over an interval of time.

…ctions and all tests passing with 100 percent cov
@R7L208 R7L208 requested a review from tnixon September 14, 2022 18:22
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #256 (c242df5) into master (38ec63f) will increase coverage by 2.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   83.15%   85.46%   +2.31%     
==========================================
  Files           5        6       +1     
  Lines         653      757     +104     
  Branches      143      161      +18     
==========================================
+ Hits          543      647     +104     
  Misses         92       92              
  Partials       18       18              
Impacted Files Coverage Δ
tempo/intervals.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tnixon
tnixon previously approved these changes Sep 19, 2022
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff!
I'm excited to see this in action.

@tnixon tnixon self-requested a review September 20, 2022 17:11
@tnixon tnixon dismissed their stale review September 20, 2022 17:12

Going to push an update to address some comments shortly

Copy link
Contributor Author

@R7L208 R7L208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnixon - changes look good to me; thank you for the help on this one

@tnixon tnixon merged commit 99bc8c1 into master Sep 22, 2022
@tnixon tnixon deleted the r7l208/dev/intervalsdf branch September 22, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support correlating metrics with overlapping time intervals
3 participants