Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for transferring ownership & key backup #828

Merged
merged 13 commits into from
Aug 4, 2017
Merged

Conversation

joehand
Copy link
Collaborator

@joehand joehand commented Jul 20, 2017

Adds a dat keys command a two subcommands: dat keys import and dat keys export.

  • dat keys - prints out dat key and discovery key
  • dat keys export - prints out secret key (does not remove ownership from existing dat)
  • dat keys import - prompts user for secret key to make a dat writable.

These are still somewhat advanced key features but will at least make it possible to backup or transfer ownership of a dat.

(#827)

@ralphtheninja
Copy link
Contributor

LGTM! Really nicely implemented.

@joehand joehand changed the title Add keys command for transffering secret keys Add keys command for transferring ownership & key backup Jul 21, 2017
@joehand joehand changed the title Add keys command for transferring ownership & key backup Add command for transferring ownership & key backup Jul 21, 2017
Copy link
Collaborator

@okdistribute okdistribute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Great job

}
}
}

function exit (err) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joehand
Copy link
Collaborator Author

joehand commented Jul 25, 2017

FYI: Waiting to fix tests before merge. Thinking that holepunchto/hypercore#109 is causing the test errors but gonna debug a bit more when mafintosh gets into town.

@joehand joehand mentioned this pull request Aug 3, 2017
@joehand joehand merged commit 20da1e9 into master Aug 4, 2017
@joehand joehand deleted the import-key branch August 4, 2017 18:25
@austinfrey
Copy link

this is documented in the README but I don't believe it's listed in the initial dat --help printout from the command line. dat keys --help will give details though. this could very well be intentional, but thought I'd mention it.

@joehand
Copy link
Collaborator Author

joehand commented Dec 11, 2017

Thanks, yes it is a bit intentional. Importing/Exporting via dat keys still has the potential to corrupt a dat with incorrect use. We'll leave it for more advanced use cases until the multiwriter lands to avoid that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants