-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command for transferring ownership & key backup #828
Conversation
LGTM! Really nicely implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Great job
src/commands/keys.js
Outdated
} | ||
} | ||
} | ||
|
||
function exit (err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
FYI: Waiting to fix tests before merge. Thinking that holepunchto/hypercore#109 is causing the test errors but gonna debug a bit more when mafintosh gets into town. |
this is documented in the README but I don't believe it's listed in the initial |
Thanks, yes it is a bit intentional. Importing/Exporting via |
Adds a
dat keys
command a two subcommands:dat keys import
anddat keys export
.dat keys
- prints out dat key and discovery keydat keys export
- prints out secret key (does not remove ownership from existing dat)dat keys import
- prompts user for secret key to make a dat writable.These are still somewhat advanced key features but will at least make it possible to backup or transfer ownership of a dat.
(#827)