Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry commands, unpublish, add some nicer messages #794

Merged
merged 9 commits into from
Jun 1, 2017

Conversation

joehand
Copy link
Collaborator

@joehand joehand commented May 31, 2017

  • Fixed some bugs in the registry commands
  • Use dat.json better again for publish + unpublish
  • Add unpublish

Login:

screen shot 2017-05-30 at 18 57 26

Publish:
screen shot 2017-05-30 at 18 57 40

Unpublish
screen shot 2017-05-30 at 18 57 56

@pfrazee
Copy link

pfrazee commented May 31, 2017

Per our IRC conversation --

Could we add a Registry: or Server: line to the login process, which has a default value of datproject.org? I think it's pretty important to convey that datproject.org is a good default, but not hardwired into dat cli.

@okdistribute
Copy link
Collaborator

It'd be cool if you could do dat publish <server> which would be a proxy for --server=

I think in the dat publish text, instead of 'datproject.org will live update when you are syncing your dat', maybe it could say something with the actual command with color: 'Don't forget to keep your data online by using dat share before sharing your link'

@joehand
Copy link
Collaborator Author

joehand commented May 31, 2017

Okay, I'll do a few updates:

  • dat login and dat register requires server option (either dat login datproject.org or dat login --server datproject.org).
    • if server not specified then prompt for server
    • default to datproject.org as server on prompt
  • dat publish, dat logout, and dat whoami:
    • print your current server (obtained from current login via township)
    • run command to that server
    • (?) dat publish: print published URL. We need server to send us back this link. (it'd be good to add the published link to dat.json, but we need spec for that).

Other bugs:

It'd be cool if you could do dat publish which would be a proxy for --server=

Yea, I'll do that for dat login. Currently, you have to already be logged in for dat publish to work. It'd be cool to prompt for login but not gonna add that for now.

@joehand
Copy link
Collaborator Author

joehand commented May 31, 2017

Okay, here is what I have for dat login and dat register (note, these require dat-ecosystem-archive/dat-registry-client#4)

Default login without server argument:
screen shot 2017-05-31 at 11 20 10

Default login with server argument:
screen shot 2017-05-31 at 11 20 31

Register to another server:
screen shot 2017-05-31 at 11 27 08

Login to another server:
screen shot 2017-05-31 at 11 27 39

@pfrazee
Copy link

pfrazee commented May 31, 2017 via email

@joehand
Copy link
Collaborator Author

joehand commented May 31, 2017

Should be all addressed! All commands dealing with registry can take another server as first argument or use the current login as default (datproject.org or otherwise). Here are a few more caps:

screen shot 2017-05-31 at 13 26 11

screen shot 2017-05-31 at 14 20 57

Copy link
Collaborator

@okdistribute okdistribute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if it said "You are not the owner of this dat" or "You can only publish a day that you created" or something along those lines? Not sure everyone will know off the bat what "writable" means.

@okdistribute
Copy link
Collaborator

woot!

@joehand joehand merged commit 3319746 into master Jun 1, 2017
@joehand joehand deleted the fix/registry-cmds branch June 1, 2017 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants