Update all (approximately) i/o operations to use ResourceProvider #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
force-pushed
the
resource-provider
branch
from
134beb6 to
df3872e
Compare
scheglov
approved these changes
Aug 20, 2020
devoncarew
reviewed
Aug 20, 2020
lib/dartdoc.dart
Outdated
|
|
||
| void checkDirectory(Folder dir) { | ||
| for (var f in dir.getChildren()) { | ||
| //if (path.basename(f.path) == '.' || path.basename(f.path) == '..') { |
There was a problem hiding this comment.
Do you intend this to be commented out?
devoncarew
reviewed
Aug 20, 2020
lib/src/io_utils.dart
Outdated
| if (this is PhysicalResourceProvider) { | ||
| return io.Platform.resolvedExecutable; | ||
| } else { | ||
| return 'TODO(srawlins)'; |
There was a problem hiding this comment.
I assume this PR is still a WIP?
There was a problem hiding this comment.
Sorry, that part is not implemented yet. It will be the part used in tests with MemoryResourceProvider. Moved TODO to comment; return null.
|
Same TargetKind crash on analyzer at HEAD. Side-stepping. |
srawlins
force-pushed
the
resource-provider
branch
from
fdb415b to
209defa
Compare
|
Side-stepping analyzer 0.40.1 breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2297
All i/o operations now pass through a ResourceProvider, an abstraction which allows disk-free testing. In this change, almost all ResourceProviders used are the PhysicalResourceProvider; no tests are converted from being filesystem-dependent to using MemoryResourceProvider.
dartdoc uses the filesystem extensively, so this change is large. Often top-level or static elements become more complicated, depending on a ResourceProvider variable.
Some extra dart:io functionality not found in ResourceProvider is added via an extension, ResourceProviderExtensions.
Many classes have a new
ResourceProvider resourceProviderfield: DartdocFileWriter, SnapshotCache, DartToolDefinition, ToolConfiguration, DartdocOption, PackageMetaProvider, PackageMeta, ToolTempFileTracker,Each of SnapshotCache and ToolTempFileTracker has a static
instancefield which took no arguments; now that they need a ResourceProvider, it was unwieldy to pass a ResourceProvider to get the instance each time, so a new method,createInstancecreates the instance.