Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dartdoc's dep on package:quiver #2305

Merged
merged 2 commits into from
Aug 17, 2020
Merged

remove dartdoc's dep on package:quiver #2305

merged 2 commits into from
Aug 17, 2020

Conversation

devoncarew
Copy link
Member

Redux of #2287.

  • remove dartdoc's dep on package:quiver
  • add some import prefixes to make more clear which packages we import but that we only use a method or two from
  • expand the supported version range for package:cli_util

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Aug 17, 2020
@devoncarew devoncarew mentioned this pull request Aug 17, 2020
Closed
@devoncarew devoncarew requested a review from srawlins August 17, 2020 05:32
@devoncarew
Copy link
Member Author

For some reasons my PRs were failing when I was using branches on the repo. I switched to creating branches on my fork - looks like the bots like that more.

srawlins
srawlins approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@devoncarew devoncarew merged commit bf552aa into dart-lang:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devoncarew @srawlins @googlebot