New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privatize some of the interface of Canonicalization, Category #2291

Merged

srawlins merged 1 commit into dart-lang:master from srawlins:privatize-1

Aug 11, 2020

Member

srawlins commented Aug 11, 2020

Deprecate the public method Canonicalization.scoreElementWithLibrary.
Deprecate the public getters ScoredCandidate.reasons and ScoredCandidate.element, method ScoredCandidate.alterScore.
Deprecate the setters Category.package, and Category.config, and the public method Category.fileType.
Deprecate the unused methods Category.linkedName and Category.categoryLabel.

These should be removed on a major release number, like 1.0.0.


          Privatize some of the interface of Canonicalization, Category

b6b0f5f

srawlins requested a review from scheglov

August 11, 2020 05:32

googlebot added the cla: yes label

scheglov approved these changes

View reviewed changes

Member Author

srawlins commented Aug 11, 2020

Side-stepping the flutter bot timeout; happening on all PRs.

srawlins merged commit 4410c77 into dart-lang:master

srawlins deleted the privatize-1 branch

August 11, 2020 13:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels