Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't HTML escape source code blocks in Markdown #2253

Merged
merged 4 commits into from
Jul 8, 2020

Conversation

jdkoren
Copy link
Contributor

@jdkoren jdkoren commented Jul 7, 2020

Adds a renderer in between to control whether or not we apply HTML
escapes to source code blocks.

Fixes #2252

Adds a renderer in between to control whether or not we apply HTML
escapes to source code blocks.

Fixes dart-lang#2252
@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jul 7, 2020
@devoncarew devoncarew requested a review from srawlins July 7, 2020 22:37
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Two small comments.

lib/src/render/source_code_renderer.dart Outdated Show resolved Hide resolved
lib/src/render/source_code_renderer.dart Show resolved Hide resolved
@jdkoren jdkoren requested a review from srawlins July 8, 2020 04:03
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@srawlins srawlins merged commit b0e2786 into dart-lang:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code blocks in Markdown output don't need HTML escapes
4 participants