Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine detection for NNBD cases and tag generated pages with "Null safety" #2221

Merged
merged 11 commits into from
May 28, 2020

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented May 27, 2020

Fixes #2210.

This puts in the basic scaffolding for tagging pages that are documenting NNBD interfaces and (mostly) boilerplate for connecting to analyzer's package list parsing support.

Tagging @mehmetf and @jdkoren as this touched PackageMeta and markdown templates, respectively.

More extensive tests will wait for a followup -- it's not vital that every case is covered for the preview.

Screen Shot 2020-05-27 at 2 44 30 PM

@googlebot googlebot added the cla: yes Google CLA check succeeded. label May 27, 2020
@mehmetf
Copy link
Contributor

mehmetf commented May 27, 2020

This is fine. In g3, we will opt to mark allowsNNBD as false until we can read this from the new packages specification.

@coveralls
Copy link

coveralls commented May 27, 2020

Coverage Status

Coverage decreased (-0.3%) to 92.684% when pulling 383e790 on nnbd-package-allow into 0b0f715 on master.

@jcollins-g jcollins-g marked this pull request as ready for review May 27, 2020 22:44
@kevmoo
Copy link
Member

kevmoo commented May 28, 2020

Do we want to go w/ null safe over NNBD? CC @mit-mit

@mit-mit
Copy link
Member

mit-mit commented May 28, 2020

Yes, please never use the term 'NNDB' externally. The external name is 'null safety'.

We recently added tags on pub.dev, I suggest we align with that, so the tag should say 'Null safety' and the tool-tip should say 'Supports the null safety language feature.'.

@jcollins-g
Copy link
Contributor Author

@mit-mit @kevmoo

Updated the feature tag appearance, text, and tool-tip to align with pub.dev.

Screen Shot 2020-05-28 at 9 41 00 AM

@jcollins-g jcollins-g changed the title Refine detection for NNBD cases and tag generated pages with "NNBD" Refine detection for NNBD cases and tag generated pages with "Null safety" May 28, 2020
@jcollins-g jcollins-g merged commit 679f3d5 into master May 28, 2020
@mit-mit
Copy link
Member

mit-mit commented May 28, 2020

Awesome, thanks

@jcollins-g jcollins-g deleted the nnbd-package-allow branch June 15, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dartdoc should show nullability of elements when experiment enabled
7 participants