Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null staticElement for const constructors #2176

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Apr 9, 2020

Part of work on #2143.

Ordinarily we don't support documenting things that do not analyze cleanly, but sky_engine does not have a fully resolved import/export tree. This works around an issue for missing imports for cases where we intentionally document sky_engine.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 9, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.778% when pulling 7d87348 on allow-null-staticelement into db5fe1c on master.

@jcollins-g jcollins-g merged commit 1cd44e6 into master Apr 10, 2020
@jcollins-g jcollins-g deleted the allow-null-staticelement branch April 27, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants