-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOSGCP-82 Changing defaults and default behaviors #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks like great changes and some of the new tickets make more sense.
As a start of Dev Cycle type patch I think these changes are good.
@@ -36,4 +44,4 @@ client_machine_type = "c2-standard-16" | |||
client_os_family = "daos-client-hpc-centos-7" | |||
client_os_project = "<project_id>" | |||
client_os_disk_type = "pd-ssd" | |||
client_os_disk_size_gb = 20 | |||
client_os_disk_size_gb = 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New line issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@cboneti After some work with terraform.tfvars.tco.example I have:
I get
Can you confirm how this daos_cluster example should work? |
b8ba38f
to
abc4085
Compare
Hi Keith, there was a bug in the cluster example, as the client yaml inputs should be automatically set by the servers yml outputs. I fixed that now and pushed a new version. |
The goal is to supporte better integrations and provide a better customer experience by adding good defaults and default behavior to the server and client modules (along with the various examples that depend on them). For now, the server defaults to optimizing for TCO. Signed-off-by: Carlos Boneti <carlosboneti@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 4 client 4 server config from "daos_cluster" is working.
The Client YML syntax needs to be fixed up . dmg command don't run out of the box as is.
Updated files in terraform/examples/only_daos_client as a result of changes in the terraform/modules/daos_client terraform module. Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DMG command are working on the default 4x4 setup in my test setup. Looks good to land to me.
The goal is to supporte better integrations and provide a better
customer experience by adding good defaults and default behavior
to the server and client modules (along with the various examples that
depend on them). For now, the server defaults to optimizing for TCO.