Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOSGCP-82 Changing defaults and default behaviors #27

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

cboneti
Copy link
Collaborator

@cboneti cboneti commented Apr 4, 2022

The goal is to supporte better integrations and provide a better
customer experience by adding good defaults and default behavior
to the server and client modules (along with the various examples that
depend on them). For now, the server defaults to optimizing for TCO.

@cboneti cboneti requested a review from markaolson April 4, 2022 21:56
@cboneti cboneti changed the base branch from main to develop April 4, 2022 21:56
@cboneti cboneti changed the title Changing defaults and default behaviors DAOS GCP-82 Changing defaults and default behaviors Apr 6, 2022
@cboneti cboneti changed the title DAOS GCP-82 Changing defaults and default behaviors DAOSGCP-82 Changing defaults and default behaviors Apr 6, 2022
Copy link
Contributor

@Kmannth Kmannth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks like great changes and some of the new tickets make more sense.

As a start of Dev Cycle type patch I think these changes are good.

@@ -36,4 +44,4 @@ client_machine_type = "c2-standard-16"
client_os_family = "daos-client-hpc-centos-7"
client_os_project = "<project_id>"
client_os_disk_type = "pd-ssd"
client_os_disk_size_gb = 20
client_os_disk_size_gb = 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line issue?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

markaolson
markaolson previously approved these changes Apr 6, 2022
Copy link
Contributor

@markaolson markaolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Kmannth
Copy link
Contributor

Kmannth commented Apr 6, 2022

@cboneti
When testing the /google-cloud-daos/terraform/examples/daos_cluster setup.

After some work with terraform.tfvars.tco.example I have:

[kmannthe@colts80-clx25 daos_cluster]$ cat terraform.tfvars
project_id                 = "mine"
region                     = "us-central1"
zone                       = "us-central1-f"

server_number_of_instances = 2
server_machine_type        = "n2-custom-36-215040"
server_os_disk_size_gb     = 20
server_daos_disk_count     = 16
server_daos_crt_timeout    = 300
server_daos_scm_size       = 180

client_number_of_instances = 4
client_preemptible         = "true"
client_mig_name            = "daos-client"
client_template_name       = "daos-client"
client_instance_base_name  = "daos-client"
client_machine_type        = "c2-standard-16"
client_os_family           = "daos-client-hpc-centos-7"
client_os_project          = "mine"
client_os_disk_type        = "pd-ssd"
client_os_disk_size_gb     = 20

I get

[kmannthe@colts80-clx25 daos_cluster]$ terraform apply
var.client_daos_agent_yml
  YAML to configure the daos agent.

  Enter a value

Can you confirm how this daos_cluster example should work?

@cboneti cboneti force-pushed the config-script branch 2 times, most recently from b8ba38f to abc4085 Compare April 6, 2022 21:43
@cboneti
Copy link
Collaborator Author

cboneti commented Apr 6, 2022

Hi Keith, there was a bug in the cluster example, as the client yaml inputs should be automatically set by the servers yml outputs. I fixed that now and pushed a new version.

The goal is to supporte better integrations and provide a better
customer experience by adding good defaults and default behavior
to the server and client modules (along with the various examples that
depend on them). For now, the server defaults to optimizing for TCO.

Signed-off-by: Carlos Boneti <carlosboneti@google.com>
Copy link
Contributor

@Kmannth Kmannth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 4 client 4 server config from "daos_cluster" is working.

The Client YML syntax needs to be fixed up . dmg command don't run out of the box as is.

Mark A. Olson added 2 commits April 7, 2022 09:09
Updated files in terraform/examples/only_daos_client
as a result of changes in the terraform/modules/daos_client
terraform module.

Signed-off-by: Mark A. Olson <mark.a.olson@intel.com>
@markaolson markaolson requested a review from Kmannth April 7, 2022 21:35
Copy link
Contributor

@Kmannth Kmannth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DMG command are working on the default 4x4 setup in my test setup. Looks good to land to me.

@markaolson markaolson merged commit bcaf110 into daos-stack:develop Apr 8, 2022
@cboneti cboneti deleted the config-script branch April 20, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants